Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect passing of parameter to visual shader preview #94729

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix incorrect passing of parameter to visual shader preview #94729

merged 1 commit into from
Jul 30, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jul 25, 2024

Currently, it doesn't work at all.

Before:

vs_param_old

After:

vs_param

@Chaosus Chaosus requested a review from a team as a code owner July 25, 2024 08:59
@Chaosus Chaosus added bug topic:editor topic:shaders cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jul 25, 2024
@Chaosus Chaosus modified the milestones: 4.4, 4.3 Jul 25, 2024
@Chaosus Chaosus removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jul 29, 2024
@Chaosus
Copy link
Member Author

Chaosus commented Jul 29, 2024

It's safe to be merged to 4.3, I guess.

@akien-mga akien-mga merged commit db79f52 into godotengine:master Jul 30, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the vs_fix_param_set branch July 30, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:shaders
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Chaosus @akien-mga